Discussion:
[users] spamass-milter patch.
Steven Haigh
2010-02-11 17:12:30 UTC
Permalink
Hi guys,

I've been fighting with spamass-milter to allow it to just accept SMTP AUTH connections and skip the spam filtering etc etc... Looks like this isn't possible with the current spamass-milter package on RF...

A simple patch is to change insert the following:

if (smfi_getsymval (ctx, "{auth_type}") != NULL) {
return SMFIS_ACCEPT;
}

After this bit of code in spamass-milter.cpp to create:

mlfi_envfrom(SMFICTX* ctx, char** envfrom)
{
SpamAssassin* assassin;
struct context *sctx = (struct context *)smfi_getpriv(ctx);
char *queueid;

if (smfi_getsymval (ctx, "{auth_type}") != NULL) {
return SMFIS_ACCEPT;
}

if (sctx == NULL)
{
debug(D_ALWAYS, "smfi_getpriv failed!");
return SMFIS_TEMPFAIL;
}
/* debug(D_ALWAYS, "ZZZ got private context %p", sctx); */

Have run this for the last couple of hours with good results. It'd be great to see this in the RF package.

--
Steven Haigh

Email: netwiz at crc.id.au
Web: http://www.crc.id.au
Phone: (03) 9001 6090 - 0412 935 897
Fax: (03) 8338 0299
Yury V. Zaytsev
2010-02-12 08:48:36 UTC
Permalink
Hi!
Post by Steven Haigh
Have run this for the last couple of hours with good results. It'd be
great to see this in the RF package.
Please provide a diff if you want to see it included.

Thanks!
--
Sincerely yours,
Yury V. Zaytsev
Steven Haigh
2010-03-06 01:53:32 UTC
Permalink
On Fri, 12 Feb 2010 09:48:36 +0100, "Yury V. Zaytsev" <yury at shurup.com>
Post by Yury V. Zaytsev
Hi!
Post by Steven Haigh
Have run this for the last couple of hours with good results. It'd be
great to see this in the RF package.
Please provide a diff if you want to see it included.
Thanks!
Hi all,

Finally got around to doing this:

diff -crB spamass-milter-0.3.1.orig/spamass-milter.cpp
spamass-milter-0.3.1/spamass-milter.cpp
*** spamass-milter-0.3.1.orig/spamass-milter.cpp 2006-03-24
08:41:36.000000000 +1100
--- spamass-milter-0.3.1/spamass-milter.cpp 2010-02-12
03:59:16.000000000 +1100
***************
*** 775,780 ****
--- 775,784 ----
SpamAssassin* assassin;
struct context *sctx = (struct context *)smfi_getpriv(ctx);
char *queueid;
+ if (smfi_getsymval (ctx, "{auth_type}") != NULL)
+ {
+ return SMFIS_ACCEPT;
+ }

if (sctx == NULL)
{

This patch will skip the spam filtering for messages sent to the SMTP
server on a SMTP AUTHed connection.
--
Steven Haigh

Email: netwiz at crc.id.au
Web: http://www.crc.id.au
Phone: (03) 9001 6090 - 0412 935 897
Fax: (03) 8338 0299
Yury V. Zaytsev
2010-03-07 13:06:15 UTC
Permalink
Post by Steven Haigh
This patch will skip the spam filtering for messages sent to the SMTP
server on a SMTP AUTHed connection.
Hi!

I'm sorry, I completely forgot about that. Should be there on the next
rebuild.
--
Sincerely yours,
Yury V. Zaytsev
Yury V. Zaytsev
2010-03-07 13:06:15 UTC
Permalink
Post by Steven Haigh
This patch will skip the spam filtering for messages sent to the SMTP
server on a SMTP AUTHed connection.
Hi!

I'm sorry, I completely forgot about that. Should be there on the next
rebuild.
--
Sincerely yours,
Yury V. Zaytsev
Yury V. Zaytsev
2010-03-07 13:06:15 UTC
Permalink
Post by Steven Haigh
This patch will skip the spam filtering for messages sent to the SMTP
server on a SMTP AUTHed connection.
Hi!

I'm sorry, I completely forgot about that. Should be there on the next
rebuild.
--
Sincerely yours,
Yury V. Zaytsev
Yury V. Zaytsev
2010-03-07 13:06:15 UTC
Permalink
Post by Steven Haigh
This patch will skip the spam filtering for messages sent to the SMTP
server on a SMTP AUTHed connection.
Hi!

I'm sorry, I completely forgot about that. Should be there on the next
rebuild.
--
Sincerely yours,
Yury V. Zaytsev
Yury V. Zaytsev
2010-03-07 13:06:15 UTC
Permalink
Post by Steven Haigh
This patch will skip the spam filtering for messages sent to the SMTP
server on a SMTP AUTHed connection.
Hi!

I'm sorry, I completely forgot about that. Should be there on the next
rebuild.
--
Sincerely yours,
Yury V. Zaytsev
Steven Haigh
2010-03-06 01:53:32 UTC
Permalink
On Fri, 12 Feb 2010 09:48:36 +0100, "Yury V. Zaytsev" <yury at shurup.com>
Post by Yury V. Zaytsev
Hi!
Post by Steven Haigh
Have run this for the last couple of hours with good results. It'd be
great to see this in the RF package.
Please provide a diff if you want to see it included.
Thanks!
Hi all,

Finally got around to doing this:

diff -crB spamass-milter-0.3.1.orig/spamass-milter.cpp
spamass-milter-0.3.1/spamass-milter.cpp
*** spamass-milter-0.3.1.orig/spamass-milter.cpp 2006-03-24
08:41:36.000000000 +1100
--- spamass-milter-0.3.1/spamass-milter.cpp 2010-02-12
03:59:16.000000000 +1100
***************
*** 775,780 ****
--- 775,784 ----
SpamAssassin* assassin;
struct context *sctx = (struct context *)smfi_getpriv(ctx);
char *queueid;
+ if (smfi_getsymval (ctx, "{auth_type}") != NULL)
+ {
+ return SMFIS_ACCEPT;
+ }

if (sctx == NULL)
{

This patch will skip the spam filtering for messages sent to the SMTP
server on a SMTP AUTHed connection.
--
Steven Haigh

Email: netwiz at crc.id.au
Web: http://www.crc.id.au
Phone: (03) 9001 6090 - 0412 935 897
Fax: (03) 8338 0299
Steven Haigh
2010-03-06 01:53:32 UTC
Permalink
On Fri, 12 Feb 2010 09:48:36 +0100, "Yury V. Zaytsev" <yury at shurup.com>
Post by Yury V. Zaytsev
Hi!
Post by Steven Haigh
Have run this for the last couple of hours with good results. It'd be
great to see this in the RF package.
Please provide a diff if you want to see it included.
Thanks!
Hi all,

Finally got around to doing this:

diff -crB spamass-milter-0.3.1.orig/spamass-milter.cpp
spamass-milter-0.3.1/spamass-milter.cpp
*** spamass-milter-0.3.1.orig/spamass-milter.cpp 2006-03-24
08:41:36.000000000 +1100
--- spamass-milter-0.3.1/spamass-milter.cpp 2010-02-12
03:59:16.000000000 +1100
***************
*** 775,780 ****
--- 775,784 ----
SpamAssassin* assassin;
struct context *sctx = (struct context *)smfi_getpriv(ctx);
char *queueid;
+ if (smfi_getsymval (ctx, "{auth_type}") != NULL)
+ {
+ return SMFIS_ACCEPT;
+ }

if (sctx == NULL)
{

This patch will skip the spam filtering for messages sent to the SMTP
server on a SMTP AUTHed connection.
--
Steven Haigh

Email: netwiz at crc.id.au
Web: http://www.crc.id.au
Phone: (03) 9001 6090 - 0412 935 897
Fax: (03) 8338 0299
Steven Haigh
2010-03-06 01:53:32 UTC
Permalink
On Fri, 12 Feb 2010 09:48:36 +0100, "Yury V. Zaytsev" <yury at shurup.com>
Post by Yury V. Zaytsev
Hi!
Post by Steven Haigh
Have run this for the last couple of hours with good results. It'd be
great to see this in the RF package.
Please provide a diff if you want to see it included.
Thanks!
Hi all,

Finally got around to doing this:

diff -crB spamass-milter-0.3.1.orig/spamass-milter.cpp
spamass-milter-0.3.1/spamass-milter.cpp
*** spamass-milter-0.3.1.orig/spamass-milter.cpp 2006-03-24
08:41:36.000000000 +1100
--- spamass-milter-0.3.1/spamass-milter.cpp 2010-02-12
03:59:16.000000000 +1100
***************
*** 775,780 ****
--- 775,784 ----
SpamAssassin* assassin;
struct context *sctx = (struct context *)smfi_getpriv(ctx);
char *queueid;
+ if (smfi_getsymval (ctx, "{auth_type}") != NULL)
+ {
+ return SMFIS_ACCEPT;
+ }

if (sctx == NULL)
{

This patch will skip the spam filtering for messages sent to the SMTP
server on a SMTP AUTHed connection.
--
Steven Haigh

Email: netwiz at crc.id.au
Web: http://www.crc.id.au
Phone: (03) 9001 6090 - 0412 935 897
Fax: (03) 8338 0299
Steven Haigh
2010-03-06 01:53:32 UTC
Permalink
On Fri, 12 Feb 2010 09:48:36 +0100, "Yury V. Zaytsev" <yury at shurup.com>
Post by Yury V. Zaytsev
Hi!
Post by Steven Haigh
Have run this for the last couple of hours with good results. It'd be
great to see this in the RF package.
Please provide a diff if you want to see it included.
Thanks!
Hi all,

Finally got around to doing this:

diff -crB spamass-milter-0.3.1.orig/spamass-milter.cpp
spamass-milter-0.3.1/spamass-milter.cpp
*** spamass-milter-0.3.1.orig/spamass-milter.cpp 2006-03-24
08:41:36.000000000 +1100
--- spamass-milter-0.3.1/spamass-milter.cpp 2010-02-12
03:59:16.000000000 +1100
***************
*** 775,780 ****
--- 775,784 ----
SpamAssassin* assassin;
struct context *sctx = (struct context *)smfi_getpriv(ctx);
char *queueid;
+ if (smfi_getsymval (ctx, "{auth_type}") != NULL)
+ {
+ return SMFIS_ACCEPT;
+ }

if (sctx == NULL)
{

This patch will skip the spam filtering for messages sent to the SMTP
server on a SMTP AUTHed connection.
--
Steven Haigh

Email: netwiz at crc.id.au
Web: http://www.crc.id.au
Phone: (03) 9001 6090 - 0412 935 897
Fax: (03) 8338 0299
Steven Haigh
2010-02-11 17:12:30 UTC
Permalink
Hi guys,

I've been fighting with spamass-milter to allow it to just accept SMTP AUTH connections and skip the spam filtering etc etc... Looks like this isn't possible with the current spamass-milter package on RF...

A simple patch is to change insert the following:

if (smfi_getsymval (ctx, "{auth_type}") != NULL) {
return SMFIS_ACCEPT;
}

After this bit of code in spamass-milter.cpp to create:

mlfi_envfrom(SMFICTX* ctx, char** envfrom)
{
SpamAssassin* assassin;
struct context *sctx = (struct context *)smfi_getpriv(ctx);
char *queueid;

if (smfi_getsymval (ctx, "{auth_type}") != NULL) {
return SMFIS_ACCEPT;
}

if (sctx == NULL)
{
debug(D_ALWAYS, "smfi_getpriv failed!");
return SMFIS_TEMPFAIL;
}
/* debug(D_ALWAYS, "ZZZ got private context %p", sctx); */

Have run this for the last couple of hours with good results. It'd be great to see this in the RF package.

--
Steven Haigh

Email: netwiz at crc.id.au
Web: http://www.crc.id.au
Phone: (03) 9001 6090 - 0412 935 897
Fax: (03) 8338 0299
Yury V. Zaytsev
2010-02-12 08:48:36 UTC
Permalink
Hi!
Post by Steven Haigh
Have run this for the last couple of hours with good results. It'd be
great to see this in the RF package.
Please provide a diff if you want to see it included.

Thanks!
--
Sincerely yours,
Yury V. Zaytsev
Steven Haigh
2010-02-11 17:12:30 UTC
Permalink
Hi guys,

I've been fighting with spamass-milter to allow it to just accept SMTP AUTH connections and skip the spam filtering etc etc... Looks like this isn't possible with the current spamass-milter package on RF...

A simple patch is to change insert the following:

if (smfi_getsymval (ctx, "{auth_type}") != NULL) {
return SMFIS_ACCEPT;
}

After this bit of code in spamass-milter.cpp to create:

mlfi_envfrom(SMFICTX* ctx, char** envfrom)
{
SpamAssassin* assassin;
struct context *sctx = (struct context *)smfi_getpriv(ctx);
char *queueid;

if (smfi_getsymval (ctx, "{auth_type}") != NULL) {
return SMFIS_ACCEPT;
}

if (sctx == NULL)
{
debug(D_ALWAYS, "smfi_getpriv failed!");
return SMFIS_TEMPFAIL;
}
/* debug(D_ALWAYS, "ZZZ got private context %p", sctx); */

Have run this for the last couple of hours with good results. It'd be great to see this in the RF package.

--
Steven Haigh

Email: netwiz at crc.id.au
Web: http://www.crc.id.au
Phone: (03) 9001 6090 - 0412 935 897
Fax: (03) 8338 0299
Yury V. Zaytsev
2010-02-12 08:48:36 UTC
Permalink
Hi!
Post by Steven Haigh
Have run this for the last couple of hours with good results. It'd be
great to see this in the RF package.
Please provide a diff if you want to see it included.

Thanks!
--
Sincerely yours,
Yury V. Zaytsev
Steven Haigh
2010-02-11 17:12:30 UTC
Permalink
Hi guys,

I've been fighting with spamass-milter to allow it to just accept SMTP AUTH connections and skip the spam filtering etc etc... Looks like this isn't possible with the current spamass-milter package on RF...

A simple patch is to change insert the following:

if (smfi_getsymval (ctx, "{auth_type}") != NULL) {
return SMFIS_ACCEPT;
}

After this bit of code in spamass-milter.cpp to create:

mlfi_envfrom(SMFICTX* ctx, char** envfrom)
{
SpamAssassin* assassin;
struct context *sctx = (struct context *)smfi_getpriv(ctx);
char *queueid;

if (smfi_getsymval (ctx, "{auth_type}") != NULL) {
return SMFIS_ACCEPT;
}

if (sctx == NULL)
{
debug(D_ALWAYS, "smfi_getpriv failed!");
return SMFIS_TEMPFAIL;
}
/* debug(D_ALWAYS, "ZZZ got private context %p", sctx); */

Have run this for the last couple of hours with good results. It'd be great to see this in the RF package.

--
Steven Haigh

Email: netwiz at crc.id.au
Web: http://www.crc.id.au
Phone: (03) 9001 6090 - 0412 935 897
Fax: (03) 8338 0299
Yury V. Zaytsev
2010-02-12 08:48:36 UTC
Permalink
Hi!
Post by Steven Haigh
Have run this for the last couple of hours with good results. It'd be
great to see this in the RF package.
Please provide a diff if you want to see it included.

Thanks!
--
Sincerely yours,
Yury V. Zaytsev
Steven Haigh
2010-02-11 17:12:30 UTC
Permalink
Hi guys,

I've been fighting with spamass-milter to allow it to just accept SMTP AUTH connections and skip the spam filtering etc etc... Looks like this isn't possible with the current spamass-milter package on RF...

A simple patch is to change insert the following:

if (smfi_getsymval (ctx, "{auth_type}") != NULL) {
return SMFIS_ACCEPT;
}

After this bit of code in spamass-milter.cpp to create:

mlfi_envfrom(SMFICTX* ctx, char** envfrom)
{
SpamAssassin* assassin;
struct context *sctx = (struct context *)smfi_getpriv(ctx);
char *queueid;

if (smfi_getsymval (ctx, "{auth_type}") != NULL) {
return SMFIS_ACCEPT;
}

if (sctx == NULL)
{
debug(D_ALWAYS, "smfi_getpriv failed!");
return SMFIS_TEMPFAIL;
}
/* debug(D_ALWAYS, "ZZZ got private context %p", sctx); */

Have run this for the last couple of hours with good results. It'd be great to see this in the RF package.

--
Steven Haigh

Email: netwiz at crc.id.au
Web: http://www.crc.id.au
Phone: (03) 9001 6090 - 0412 935 897
Fax: (03) 8338 0299
Yury V. Zaytsev
2010-02-12 08:48:36 UTC
Permalink
Hi!
Post by Steven Haigh
Have run this for the last couple of hours with good results. It'd be
great to see this in the RF package.
Please provide a diff if you want to see it included.

Thanks!
--
Sincerely yours,
Yury V. Zaytsev
Loading...